fix(curriculum):Add tests for universal selector in CSSHelp#562
Closed
Iyeroo wants to merge 1 commit intofreeCodeCamp:mainfrom
Closed
fix(curriculum):Add tests for universal selector in CSSHelp#562Iyeroo wants to merge 1 commit intofreeCodeCamp:mainfrom
Iyeroo wants to merge 1 commit intofreeCodeCamp:mainfrom
Conversation
Added tests for the universal selector functionality in CSSHelp, including cases for existing and non-existent selectors.
Contributor
|
please make these changes in #561 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(curriculum):Added tests for the universal selector functionality in CSSHelp, including cases for existing and non-existent selectors.
Checklist:
Update index.md)Closes #64218
This test file verifies the behavior of the CSSHelp class with respect to universal selectors (
*).Specifically, it tests that:
CSS rules containing universal selectors are only matched when explicitly requested.
span[class~="one"] *:first-of-typeshould match only when the exact selector is requested viagetStyle.Non-existent or disallowed selectors return
nullas expected.Implementation notes:
global.CSSRuleto allow TypeScript compilation in a Node environment, sinceCSSRuleis normally a browser global.getPropValis verified to ensure that the helper method added bygetStylereturns correct CSS property values.These tests ensure that the fix preventing implicit matching of universal selectors works correctly.