feat: add Typescript function regex support#563
feat: add Typescript function regex support#563a2937 wants to merge 6 commits intofreeCodeCamp:mainfrom
Conversation
majestic-owl448
left a comment
There was a problem hiding this comment.
what's the difference between . and [\w\W]?
|
I panicked. They're probably identical. I could probably have used only the one regex symbol rather than both. |
|
Okay I tried something a little less extreme and added tests for the other regex. How's it look? |
majestic-owl448
left a comment
There was a problem hiding this comment.
could you try instead adding the pattern for types? adding something that can match anything seems dangerous
|
Please tell me this is close to what you meant. My goal was to make it so that way there's a function specifically there for Typescript Types. And it could be modified such that specific types can be added as a parameter. |
|
We are thinking of adding AST-based helpers for TypeScript as well. So this might not be necessary. I'll keep you posted. |
Checklist:
Update index.md)Closes #XXXXX
This adds support to the Function regex in order to handle functions like
which won't match under the current set of helpers. Additionally there are no breaking changes if the tests are to be believed.