Conversation
|
Oh I also forgot to update the tests. |
There was a problem hiding this comment.
Hi @a2937, this seems like a good thing to add. Could you write a test to lock this down? It would help to have a test so people can see the use-case.
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
|
The way the tests are written with a |
|
Unless I maybe try updating the Python evaluator too? |
|
It's a bit of a hassle, sure, but I'm trying to keep things as consistent as possible. That said, there are some differences between the evaluators and there are some tests that only care about specific ones. Maybe if you describe the use case I can help? Either way, don't worry about all the failing tests until we have new tests for the new functionality. |
|
I wanna be able to display some kind of help message in the console to campers based on what kind of unexpected error they received. Like to explain what a reference error is and how to fix it; along with the standard information that a failed test gives you. |
|
I see, thanks. The issue is that tests can throw errors and it would be confusing if we started explaining those errors to campers. After all, they're not expected to see test code. Perhaps if |
Checklist:
Update index.md)Closes #XXXXX
This PR might need some internal discussion but I wanted to record the error type for JavaScript lessons as well for potential future error messages.