Skip to content

Conversation

@arthurkehrwald
Copy link
Collaborator

  • Remove unneccessary HideInInspector attributes from CoilSoundComponent and SwitchSoundComponent. These classes have custom inspectors anyways and the HideInInspector attribute makes it impossible to debug those using the Debug view in the inspector.
  • Fix: Bumper coil was not triggering status events. This was broken in b890c47. It caused the bumper sound effect to not play.
  • Fix: Bumper coil is named after bumper game object. This didn't really break anything because the bumper API ignores the ID of the requested coil, but it did cause the coil sound inspector to stop showing the "Ring Coil" text whenever the name of the bumper prefab was changed. The bumper coil now always has the id "ring_coil" just like the switch always has the id "socket_switch".

These classes have custom inspectors anyways and the HideInInspector attribute makes it impossible to debug those using the Debug view in the inspector.
This didn't really break anything because the bumper API ignores the ID of the requested coil, but it did cause the coil sound inspector to stop showing the "Ring Coil" text whenever the name of the bumper prefab was changed.
Copy link
Owner

@freezy freezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot!

@freezy freezy merged commit d42d76f into freezy:master Mar 17, 2025
2 checks passed
@freezy freezy mentioned this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants