CalendarColumnConverter: Fixed null handling and precision with DateT… #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime values. - Null handling was broken. - using java.util.Date instead of java.sql.Date. java.sql.Date drops the Time and only stores the Date.
Contributor
|
Die Aufgabe des Converters ist die Konvertierung von java.util.Date in den passenden SQL Datentypen. Über den SQL-Type wird gesteuert, ob es in einen sql.Timestamp oder in ein sql.Date konvertiert wird. Deine Änderung scheint mir erstmal nicht richtig zu sein. - der Nullness part aber natürlich schon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ime values.
java.sql.Date drops the Time and only stores the Date.