call the Froala.initialized event with proper context#214
Open
mephju wants to merge 1 commit intofroala:masterfrom
Open
call the Froala.initialized event with proper context#214mephju wants to merge 1 commit intofroala:masterfrom
mephju wants to merge 1 commit intofroala:masterfrom
Conversation
Author
|
According to https://www.froala.com/wysiwyg-editor/docs/events#initialized the event's context should be the editor itself. Therefore I added this line of code that will properly provide the context to the event consumer: |
|
It would be easier to just change line 114 in the original code from: |
|
Could this be merged in please? This solves a huge pain I have to be able to get the editor on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.