Open
Conversation
New() for pandora.go
- Start() happy path for connection wait
- Start() happy path for done event
- Start() happy path for subscription err ch
- Start() happy path for seal request
- Start() failure path for seal request
- Start() happy path for seal request (still failing, TODO present)
- Start() happy path for seal request
- Start() happy path for seal request without any changes, fail path for sharding request
- Start() fail path for sharding request
- Start() covered with all ifs within
- Start() covered with all ifs within - Fmt now pass
- Remove todo
- added skip on facebook test and golang binding test
- added skip on facebook test and golang binding test
Try to support ubuntu 18.04
Release/l15 testnet tests
…ereum into fix/panic-on-glibc-ci-cd
Fix in test about epochInfo turned to cache
Fix: panic on glibc ci/cd
Added faucet support and docker build
Frontend changes
…ereum into feature/l15-faucet
Faucet is now able to synchronize
- refactored a bit confirmation logic, but still need to remove it
- little refactor
- little refactor, lint
- little refactor, lint, lint
meta-bot
reviewed
Aug 27, 2021
meta-bot
left a comment
meta-bot
left a comment
There was a problem hiding this comment.
I've several questions about the advance header validation and block validation. I think it must be resolved before accepting the merge.
Owner
|
Can you explain your thinking on the block verification flow @blazejkrzak ? |
- very hardcoded, insecure state
- rollback of insecure state
- change of the faucet title
- move dockerfile creation to root directory
- content and visual changes - removed facebook handler
- visual changes of html
Author
|
we are far ahead of this changeset in develop candidate. I will either:
|
Signed-off-by: mxmar <macht4tech@gmail.com>
|
I updated the tweet template to look like this:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is for the faucet-specific implementation. It is run in l15 prod namespace