Open
Conversation
ghost
marked this pull request as ready for review
| - DATABASE_URL=postgres://postgres:password@db | ||
| - RAILS_ENV | ||
| - RACK_ENV | ||
| - DATABASE_CLEANER_ALLOW_REMOTE_DATABASE_URL |
Contributor
There was a problem hiding this comment.
Could you please add this variable to .env.example? Something like this:
# Allow connect to remote database (in separate container)
DATABASE_CLEANER_ALLOW_REMOTE_DATABASE_URL=true
| - DATABASE_CLEANER_ALLOW_REMOTE_DATABASE_URL | ||
| - AUTH_SECRET_TOKEN | ||
| - MAILER_SENDER_ADDRESS | ||
| - PASSWORD_RECOVERY_LINK_TEMPLATE |
Contributor
There was a problem hiding this comment.
I guess this variable isn't need in this project
Suggested change
| - PASSWORD_RECOVERY_LINK_TEMPLATE |
| links: | ||
| - db | ||
| volumes: | ||
| - ruby-bundle:/usr/local/bundle |
There was a problem hiding this comment.
Maybe also use separate volume for node_modules folder? Seems like now container will use node_modules from the host machine? (because of .:/app volume). If so, I think it's no good because of different dependencies between diff machines (MacOS Host, Linux container)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary