Refactor global state: Move global variables inside the classes#80
Closed
norilanda wants to merge 9 commits intofuhrmanator:masterfrom
Closed
Refactor global state: Move global variables inside the classes#80norilanda wants to merge 9 commits intofuhrmanator:masterfrom
norilanda wants to merge 9 commits intofuhrmanator:masterfrom
Conversation
…FamixTypeScriptImporter into refactor-global-state
fuhrmanator
reviewed
Jul 3, 2025
Owner
fuhrmanator
left a comment
fuhrmanator
left a comment
There was a problem hiding this comment.
Apart from the Process module/class being encapsulated, I don't see trouble with the rest, especially with the tests that pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.