Skip to content

Docs: Document how to include Sketches in Reports (FLCRM-20058)#35

Open
nehilor wants to merge 6 commits intov2from
feature/FLCRM-20058-sketches-docs
Open

Docs: Document how to include Sketches in Reports (FLCRM-20058)#35
nehilor wants to merge 6 commits intov2from
feature/FLCRM-20058-sketches-docs

Conversation

@nehilor
Copy link
Contributor

@nehilor nehilor commented Mar 5, 2026

Summary

This PR updates the Report Builder documentation to include instructions and examples on how to incorporate Sketches into custom reports. It adds the missing SKETCHURL function reference and provides a new dedicated example page for better developer guidance.

Jira Ticket

FLCRM-20058

Changes

1. Documentation of SKETCHURL Function

  • Updated docs/REPORT BUILDER/reports-introduction/functions.md to include the SKETCHURL(id, options) function.
  • Updated the RENDERVALUES global function example to include logic for isSketchElement, showing how to render sketches alongside photos and signatures.

2. New Sketches Example Page

  • Created docs/REPORT BUILDER/reports-examples/sketches.md which provides:
    • A code snippet for the BODY section of a report.
    • Instructions on how to resize sketches via CSS styles.
    • An example of how to access a specific sketch using a field's data name.

3. Navigation & Consistency

  • Added the new Sketches example to docs/REPORT BUILDER/reports-examples/_order.yaml to ensure it appears in the documentation portal's sidebar.
  • Standardized formatting in functions.md:
    • Replaced *** horizontal rules with ---.
    • Enforced the use of double quotes in JS examples.
    • Added missing semicolons for code consistency.

How to Verify

  1. Review the modified functions.md and ensure the SKETCHURL section is accurate.
  2. Verify the new sketches.md example file follows the project's documentation style.
  3. Confirm that the _order.yaml correctly references the new file.

Copilot AI review requested due to automatic review settings March 5, 2026 17:11
@nehilor nehilor requested review from a team as code owners March 5, 2026 17:11
@nehilor nehilor self-assigned this Mar 5, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Report Builder docs to explain how to include Sketch fields in custom reports, adding the missing SKETCHURL function reference and a dedicated example page.

Changes:

  • Added documentation for SKETCHURL(id, options) in the functions reference.
  • Extended the RENDERVALUES example to render sketches alongside other media types.
  • Added a new “Sketches” examples page and included it in the examples navigation order.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File Description
docs/REPORT BUILDER/reports-introduction/functions.md Adds SKETCHURL docs and updates existing examples/formatting
docs/REPORT BUILDER/reports-examples/sketches.md New example page showing how to render and style sketches
docs/REPORT BUILDER/reports-examples/_order.yaml Adds the new sketches page to the sidebar order

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor Author

@nehilor nehilor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied feedback: downgraded headings in sketches.md to H2 for consistency.

m1g
m1g previously approved these changes Mar 6, 2026
Copy link

@m1g m1g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.. just one note

Copilot AI review requested due to automatic review settings March 6, 2026 20:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Added comprehensive documentation for SKETCHURL function parameters and options
- Documented sketch data structure (mediaID, caption, isEmpty properties)
- Added examples for accessing sketch data and handling empty fields
- Included practical examples for common use cases:
  - Display only first sketch
  - Access specific sketch by field name
  - Add metadata (creation dates) to sketches
  - Hide labels when field is empty
  - Number sketches automatically
  - Grid layout for multiple sketches
  - Page break handling
- Improved metadata with better title, description, and robots index
- Added code examples for querying sketch metadata from database
- Included CSS examples for responsive layouts and styling
m1g
m1g previously approved these changes Mar 9, 2026
Copy link
Contributor

@corporealshift corporealshift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consolidate on mediaID for all examples for consistency. We should also remove caption from sketch examples since we don't have a way to save a caption yet

- Restore missing code fence in RENDERVALUES example
- Remove trailing comma from RENDER params for wider JS compatibility
- Replace curly quotes in STATICMAP examples with straight quotes
- Standardize sketch examples to use mediaID
- Remove sketch caption examples not currently supported
- Switch EJS snippets in sketches docs to html fenced blocks
Copilot AI review requested due to automatic review settings March 9, 2026 18:14
@nehilor
Copy link
Contributor Author

nehilor commented Mar 9, 2026

Addressed all review feedback in commit f512658.

Summary of fixes:

  • Restored missing code fence in example
  • Removed trailing comma in params for broader JS compatibility
  • Replaced curly quotes in STATICMAP snippets with straight quotes
  • Standardized sketch docs to examples
  • Removed sketch caption examples that are not supported
  • Updated EJS snippets in sketches docs to fences

All review threads are now resolved.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nehilor
Copy link
Contributor Author

nehilor commented Mar 9, 2026

Addressed all review feedback in commit f512658.

Summary of fixes:

  • Restored missing code fence in RENDERVALUES example
  • Removed trailing comma in RENDER params for broader JS compatibility
  • Replaced curly quotes in STATICMAP snippets with straight quotes
  • Standardized sketch docs to mediaID examples
  • Removed sketch caption examples that are not supported
  • Updated EJS snippets in sketches docs to html fences

All review threads are now resolved.

1 similar comment
@nehilor
Copy link
Contributor Author

nehilor commented Mar 9, 2026

Addressed all review feedback in commit f512658.

Summary of fixes:

  • Restored missing code fence in RENDERVALUES example
  • Removed trailing comma in RENDER params for broader JS compatibility
  • Replaced curly quotes in STATICMAP snippets with straight quotes
  • Standardized sketch docs to mediaID examples
  • Removed sketch caption examples that are not supported
  • Updated EJS snippets in sketches docs to html fences

All review threads are now resolved.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants