Skip to content

Fix RNG #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
funmaker merged 3 commits into from
Jan 19, 2026
Merged

Fix RNG #55

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
976d1ff
Set order by to fix undefined behavior
LilianBoulard Jan 11, 2026
3ca87f4
Fix RNG
LilianBoulard Jan 11, 2026
ae9cca9
Remove ORDER_BY
LilianBoulard Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions server/controllers/posts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,26 @@ export async function random(query: string | null = null): Promise<PostSummary |
id = post?.id || null;
} else {
const key = getCacheKey(query);
const cachePage = await getCachedPosts(key);

id = cachePage.posts[Math.floor(Math.random() * cachePage.posts.length)] || null;

key.offset = 0;
const firstPage = await getCachedPosts(key);
const total = firstPage.total;

if(total === 0) {
id = null;
} else {
// Pick a random position across the entire result set
const randomPosition = Math.floor(Math.random() * total);

// Calculate which cache page contains this position
const cacheStart = Math.floor(randomPosition / CACHE_SIZE) * CACHE_SIZE;
key.offset = cacheStart;
const cachePage = await getCachedPosts(key);

// Get the post at the random position within this page
const indexInPage = randomPosition - cacheStart;
id = cachePage.posts[indexInPage] || null;
}
}

const post: PostSummary | null = await db.queryFirst(SQL`
Expand Down