Feature native facebook login#44
Open
COCPORN wants to merge 7 commits intofuse-open:feature-NativeFacebookLoginfrom
Open
Feature native facebook login#44COCPORN wants to merge 7 commits intofuse-open:feature-NativeFacebookLoginfrom
COCPORN wants to merge 7 commits intofuse-open:feature-NativeFacebookLoginfrom
Conversation
The main functionality is now in the FacebookLogin Uno project
Otherwise we get strange crashes on certain devices in certain orientations.
…veFacebookLogin Conflicts: Samples/NativeFacebookLogin/FacebookLogin/FacebookLogin.uno Samples/NativeFacebookLogin/FacebookLogin/FacebookLogin.unoproj Samples/NativeFacebookLogin/README.md
…ying it in the UX
ollef
reviewed
Jan 30, 2017
Contributor
ollef
left a comment
There was a problem hiding this comment.
Hey, thanks!
This is nice! Precisely what the sample was missing.
Would you like to do the iOS implementation as well or should we take over?
Author
|
Unless it is a rush, I can look at the iOS implementation also. Then we can get to the bottom of that issue I had previously about getting it to work with fuse preview also. |
Contributor
|
Excellent, thanks! |
Contributor
|
Is this finished yet? Documentation is linking to it, but it is not yet on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For getting the actual string accesstoken, this seems to work for Android, iOS implementation not started yet, but is probably similar and trivial