Replace FTNetworkTracer with observer middleware #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ware - Remove hard dependency on FTNetworkTracer package - Introduce NetworkObserver protocol with type-safe associated Context - Support array of middlewares for multiple observers - Zero overhead when no observers configured (empty array = no work) - Use RequestToken pattern for type erasure while preserving type safety Breaking change: `networkTracer: FTNetworkTracer?` replaced with `networkObservers: [any NetworkObserver]`
Explicitly document that `didReceiveResponse` is always invoked with raw data, and `didFail` is an additional callback for errors occurring after the response is received. Update tests to assert this behavior.
ssestak
force-pushed
the
refactor/replace-tracer-with-observer-middleware
branch
from
72cbaaa to
87b0bb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor network observation mechanism from a single tracer to a flexible observer protocol. This change replaces the concrete
FTNetworkTracerdependency with a newNetworkObserverprotocol, allowing for multiple custom observers. TheURLServernow supports an array of observers that receive lifecycle callbacks for each request.Key Features:
FTNetworkTracerdependency with a protocol-orientedNetworkObserver, enhancing flexibility and extensibility.URLServernow manages an array ofNetworkObserverinstances, enabling different modules to independently observe network events.NetworkObserverprotocol uses anassociatedtype Contextto pass correlation data (e.g., request ID, start time) betweenwillSendRequestand subsequent completion callbacks.NetworkObserverTestsand aMockNetworkObserverdemonstrate better test isolation and clarity.Package.swift: Removed the external dependency onFTNetworkTracer.Changes Summary:
FTNetworkTracer?[any NetworkObserver]FTNetworkTracerNetworkObserverprotocolrequestId,startTimeassociatedtype Contextmanaged by observerNetworkTracerIntegrationTests(deleted)NetworkObserverTests(new)