Open
Conversation
Major revision of the patch to function similar to other vim plugins, enabled autodetection of color reliably, cleaned up the source tree, and provided a simpler user interface which prevents unintended reloading of the patch.
Large revision with the following changes: - added reliable support for color autodection. This is now accomplished through a vimscript and the result is passed to the dll - restructured the repository as a standard Vim package. The entire folder can now be copied to a standard package directory such as $HOME\vimfiles\bundle - implementation of the fix for users is greatly simplified, see README.md - the dll's now can and should live in the package directory. No need to copy them to C:\Program Files\Vim\vim80. Therefore I removed the install.bat files. - build.bat is slightly changed to address the new package structure
Merged changes from latest version of gabr/FixGVimBorder. Adds LICENSE, and support for LoadFixGVimBorderWithoutAutocentering()
Added user-facing functions for centering as well as enabled autodetection of whether centering should occur. See README.md for more details.
Closed
Owner
|
Looks great. I will review and merge it in next week. |
Owner
|
I've got sick and don't know when I will have time to review and merge your work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've merged my changes with the latest branch of gabr/FixGVimBorder and tested the pull. Should be able to be pulled with no conflicts. Please see README of my branch for a discussion of the change in functionality. Features that I've added include:
if("has gui_running")blockI understand if you dislike the folder structure, I can keep my fork going instead but wanted to
see if you would appreciate the updates :) cheers!