Skip to content

Fix printing normal form games#757

Merged
tturocy merged 2 commits intomasterfrom
fix-WriteHTMLFile
Feb 9, 2026
Merged

Fix printing normal form games#757
tturocy merged 2 commits intomasterfrom
fix-WriteHTMLFile

Conversation

@edwardchalstrey1
Copy link
Member

Description of the changes in this PR

@tturocy I noticed that after recent changes when you view a normal form game in jupyter the printed html is duplicated:

Screenshot 2026-02-05 at 09 45 57

I've made a temporary fix with out looking properly into how the code works and now we get the game printed just once:
Screenshot 2026-02-05 at 09 48 07

How to review this PR

@tturocy I can take more of a look into this but you may know a quick fix

@tturocy
Copy link
Member

tturocy commented Feb 5, 2026

Did you try a git bisect to identify where this happened? I don't recall specifically doing anything which ought to cause this but it could have been an accidental brace-misplacement issue as a side effect of some other cleanups.

@edwardchalstrey1
Copy link
Member Author

@tturocy Thanks for the git bisect suggestion. Not used that before, very useful!

Looks like the problem commit was: fce4766

@edwardchalstrey1 edwardchalstrey1 marked this pull request as draft February 6, 2026 11:23
@edwardchalstrey1 edwardchalstrey1 changed the title Fix WriteHTMLFile func used when printing normal form games Fix printing normal form games Feb 6, 2026
This corrects the implementation of StrategySupportProfile::RestrictTo(); the previous implementation
was failing to set the (singleton) strategy list.
@tturocy tturocy marked this pull request as ready for review February 9, 2026 12:25
@tturocy tturocy merged commit c4eeb37 into master Feb 9, 2026
26 checks passed
@tturocy tturocy deleted the fix-WriteHTMLFile branch February 9, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants