Skip to content

Restrict search space for enumpoly to be strictly interior. #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tturocy wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Restrict search space for enumpoly to be strictly interior. #764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/solvers/enumpoly/efgpoly.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ std::list<MixedBehaviorProfile<double>> SolveSupport(const BehaviorSupportProfil

// set up the rectangle of search
Vector<double> bottoms(data.space->GetDimension()), tops(data.space->GetDimension());
bottoms = 0;
tops = 1;
bottoms = 1e-12;
tops = 1 - 1e-12;

PolynomialSystemSolver solver(equations);
std::list<Vector<double>> roots;
Expand Down
4 changes: 2 additions & 2 deletions src/solvers/enumpoly/nfgpoly.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ EnumPolyStrategySupportSolve(const StrategySupportProfile &support, bool &is_sin
const PolynomialSystem<double> equations = ConstructEquations(space, support, strategy_poly);

Vector<double> bottoms(space->GetDimension()), tops(space->GetDimension());
bottoms = 0;
tops = 1;
bottoms = 1e-12;
tops = 1 - 1e-12;
PolynomialSystemSolver solver(equations);
is_singular = false;
std::list<Vector<double>> roots;
Expand Down
6 changes: 5 additions & 1 deletion src/solvers/enumpoly/poly.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,11 @@ template <class T> class Polynomial {
});
}
[[nodiscard]] const std::vector<Monomial<T>> &GetTerms() const noexcept { return m_terms; }
bool IsZero() const noexcept { return m_terms.empty(); }
bool IsZero() const noexcept
{
return m_terms.empty() || std::all_of(m_terms.begin(), m_terms.end(),
[](const auto &mono) { return mono.IsZero(); });
}
bool IsConstant() const noexcept
{
return m_terms.size() == 1 && m_terms.front().TotalDegree() == 0;
Expand Down
Loading