Skip to content

Conversation

@google-labs-jules
Copy link

Implemented --feature argument support in build.sh, build.bat, and build.ps1 to allow enabling optional features like AVIF. When --feature avif is passed, the build scripts now correctly set -DWITH_AVIF=ON and include avif in the VCPKG_MANIFEST_FEATURES passed to CMake. This ensures both the code compilation flags and the dependency installation are handled correctly without requiring manual vcpkg invocation.


PR created automatically by Jules for task 10486753616765180416 started by @gameknife

- Updated `build.sh` to parse `--feature <val>`:
  - Adds `-DVCPKG_MANIFEST_FEATURES=<val>` to CMake.
  - Adds `-DWITH_AVIF=ON` if feature is `avif`.
- Updated `build.bat` to parse `--feature` and pass it to `build.ps1`.
- Updated `build.ps1` to accept `-Feature` parameter and configure CMake accordingly.

This allows building with AVIF support via:
`./build.sh --feature avif`
`build.bat --feature avif`

Resolves #196
@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant