Improve nice gens functionality and docs#278
Draft
ssiccha wants to merge 12 commits intogap-packages:masterfrom
Draft
Improve nice gens functionality and docs#278ssiccha wants to merge 12 commits intogap-packages:masterfrom
ssiccha wants to merge 12 commits intogap-packages:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
- Coverage 77.86% 77.86% -0.01%
==========================================
Files 43 43
Lines 18389 18388 -1
==========================================
- Hits 14319 14318 -1
Misses 4070 4070
|
That is install it as a method for `NiceGens` with two arguments. Also improves the documentation of `NiceGens`.
CalcNiceGensGeneric is the method for leaf nodes. So that it doesn't make sense to set this for every node by default. Maybe it once had a different function?
Will be handled during the renaming project.
Collaborator
Author
|
It looks like this will become a bigger undertaking. 😅 For now I'll add a lot of experimental code to this PR. |
Collaborator
Author
|
When this is done, @aniemeyer would like to have a look at the docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far three commits:
CalcNiceGens(r,g)intoNiceGens(r,g)CalcNiceGensand instead install it as a method forNiceGenswith two arguments. Also improves the documentation ofNiceGens.After that I suggest to rename as follows:
NiceGens->NiceGeneratorscalcnicegens->NiceGeneratorsFunctionCalcNiceGensGeneric->NiceGeneratorsForLeafRecogNodesCalcNiceGensHomNode->NiceGeneratorsForSplitRecogNodespregensfac->PreImagesOfNiceGeneratorsOfImageRecogNodeHere the corresponding input for mine and @FriedrichRober's script so that I don't loose it: