Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rest of the constructive recognition code written by @danielrademacher for his thesis.
The code in this PR has diverged from PR #371, and will need to be re-integrated with that, and of course master.
Note that I decided to discard the history from Daniel's repository; first off, it would have been a major pain to migrate it (the repository was not a fork of the recog repo, but rather a fresh repository that imported some version of the recog code, but I was not able to determine which exactly). Secondly, I don't think it is useful for the public to see what Daniel tried etc. over time.
I would also like to emphasize that Daniel never got around to "polishing" this code. There are some functions which "obviously" could be implemented much better, but that's not because Daniel wasn't aware, but because he was very good in deciding to not waste time on optimizing stuff while writing a prototype. Just write the first thing that comes to mind, and if it all comes together in the end, sit down and do it properly.
Anyway: I am not sure we'll ever merge this PR as-is, it may rather end up as a "quarry" from which we take code and get it merged in separate PRs.