You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes#15. This approach is a bit clunky in places. The use of an anonymous function with an unused parameter in ParseGapIntmatToSingBigintmat, for example, makes me cringe, but I couldn't find any other way of writing a bigintmat expression with literal elements. My hope is that those with more knowledge of GAP and Singular can help polish this up.
I expected this to work for all 4.x versions of Singular. I looked in the original Singular 4.0.0 release from December 2013, and saw bigintmat in use there. Perhaps the syntax used in this patch is only supported in newer versions of Singular? What version of Singular is used to run the tests?
Here's a version that works for me on Fedora 39, which has gap 4.12.2 and Singular 4.3.1p1. It appears that bigintvec was not introduced until Singular 4.4, so I have omitted mention of it from the tests. Probably there should be a separate test file that is executed only if Singular 4.4 is in use. This version of the patch almost works on Fedora 42, which has gap 4.14.0 and Singular 4.4.1, except the total number of inputs and outputs is 1156 instead of 1150. It would still be helpful to know what version of Singular is used by the CI.
Ah, interesting, all of the CI failures show the 1150 vs 1156 difference. I wonder why I'm getting 1150 on Fedora 39? Well, it's a dead distribution, so 1156 it is.
❌ Patch coverage is 77.77778% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.54%. Comparing base (d9b3ee7) to head (a4dfb20). ⚠️ Report is 1 commits behind head on master.
Now I wonder if the check for '[' is really needed. I added that due to a weird failure on Fedora 39. Perhaps something was broken in either the gap package or the Singular package in Fedora 39. I'm going to try taking that out. If CI fails, I'll put it back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15. This approach is a bit clunky in places. The use of an anonymous function with an unused parameter in ParseGapIntmatToSingBigintmat, for example, makes me cringe, but I couldn't find any other way of writing a bigintmat expression with literal elements. My hope is that those with more knowledge of GAP and Singular can help polish this up.