Conversation
Use key insensitive whitelist keys for secret data
…eedCandidateDeterminationStrategy` set in dashboard config
|
@holgerkoser You have pull request review open invite, please check |
petersutter
reviewed
Mar 7, 2023
holgerkoser
reviewed
Mar 13, 2023
holgerkoser
reviewed
Mar 13, 2023
petersutter
reviewed
Mar 14, 2023
petersutter
reviewed
Mar 14, 2023
… between text area data and parsed yaml (secret data)
…oard into enh/generic_cloudprovider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR has several improvements regarding unsupported cloud providers.
If no (valid) cloud provider is configured that the dashboard supports, this will no longer result in an fatal error 500. Instead this will be rendered as an information in the dashboard


Added a generic secret dialog as well as fallback implementation for all required code parts. Start implementing support for a new cloud provider is now as simple as adding the name of the new provider to the list of supported providers. This will be further enhanced with follow-up PR #1436
Added support for Gardener


localinfrastructure providerWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: