Make Retry Period configurable

[viragvoros]

This PR makes the retry period used when machine creation fails with a codes.ResourceExhausted error configurable.

PR #981 introduced the LongRetry retry period (10 minutes) to handle situations where machine creation fails due to exhausted resources. However, in certain environments this retry duration may still be insufficient.
To improve flexibility, this PR allows operators to adjust the retry period used specifically for the ResourceExhausted error case. The default behavior stays unchanged: if no value is provided as a a command-line flag (--resource-exhausted-retry) to the machine-controller-manager-provider, the controller continues to use machineutils.LongRetry.

Which issue(s) this PR fixes:
Fixes #977
Extends logic introduced in PR #981 to make the retry duration configurable.

Special notes for your reviewer:
The implementation keeps the existing default behavior unchanged:

• The ResourceExhausted retry period defaults to machineutils.LongRetry.
• The value can be optionally overridden with --resource-exhausted-retry CLI flag in machine-controller-manager-provider.
• The override is applied once during startup before the controller begins running.

No changes are required for existing deployments unless operators want to configure the retry duration.

Release note:

machine-controller-manager now allows configuring the retry duration for ResourceExhausted errors during machine creation with the `--resource-exhausted-retry` CLI flag in machine-controller-manager-provider. If not specified, the default `machineutils.LongRetry` stays unchanged.

@Kumm-Kai @hasit97

[gardener-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elankath for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[CLAassistant]

All committers have signed the CLA.

[gardener-prow]

Welcome @viragvoros!

It looks like this is your first PR to gardener/machine-controller-manager 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if gardener/machine-controller-manager has its own contribution guidelines.

Thank you, and welcome to Gardener. 😃

[Kumm-Kai]

Thanks @viragvoros 🙂
I'm not 100% certain than changing the retry period for all cases where LongRetry is used doesn't cause any side effects 🤔 At least the SafetyOptions are not affected by it, but a lost of stuff is using LongRetry.

[viragvoros]

@Kumm-Kai So an entirely new retry period variable would be better maybe?

[Kumm-Kai]

@Kumm-Kai So an entirely new retry period variable would be better maybe?

I would say that both approaches are valid, but at least from our POV, as we are only interested in the ResourceExhausted retry period, a specific setting would introduce only a single timing change.

[thiyyakat]

Hi! Thanks for the PR. Just a few changes to maintain consistency with existing code. PTAL.

[thiyyakat]

This field can be added to MachineControllerManagerConfiguration in pkg/options/types.go instead.

[viragvoros]

Hi @thiyyakat, thank you for the review :) I added the changes. In this comment, did you mean the pkg/util/provider/options/types.go MachineControllerConfiguration? The variable was intended to be introduced only in the MachineController not in the outer main.

[thiyyakat]

Hi! Yes, you're absolutely right. Apologies.

[thiyyakat]

This can be of type fs.DurationVar like so:

fs.DurationVar(&s.ResourceExhaustedRetryDuration.Duration, "resource-exhausted-retry", time.Duration(machineutils.LongRetry), "Retry duration used when machine creation fails with ResourceExhausted. Defaults to LongRetry.")

This way the default is set to machineutils.LongRetry here itself.

Please also add validation for this option below in the Validate() method.

if s.ResourceExhaustedRetryDuration.Duration < 0 { errs = append(errs, fmt.Errorf("resource exhausted retry duration should be a non negative value: got: %v", s.ResourceExhaustedRetryDuration.Duration)) }