Exclude terminating machines when managing machineset replicas#1086
Open
takoverflow wants to merge 3 commits intogardener:masterfrom
Open
Exclude terminating machines when managing machineset replicas#1086takoverflow wants to merge 3 commits intogardener:masterfrom
takoverflow wants to merge 3 commits intogardener:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
thiyyakat
reviewed
Mar 12, 2026
Member
thiyyakat
left a comment
There was a problem hiding this comment.
Hi! Thanks for the PR. Just one small suggestion. PTAL.
Member
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 340a0ae2f8c56893fbdfa779348d597536173d23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Excludes considering terminating machines in machineset controller when
computing the necessary machines that need to be created/removed.
A machine will only move to terminating state once the machine set has been scaled-down
hence if a machine is already in terminating state, it should be excluded from the list
of machines that are being considered when computing the active replicas of a machine set.
The only other scenario where a machine moves to terminating is when its in
Failedstateand the MCS controller proceeds to consider it as a stale machine and marks it
for removal. In this case, by excluding the terminating machine from diff computation,
we ensure that a replacement machine is spawned for the failed machine.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Release note: