[WIP] Group LRAM timings by cell configuration#29
Open
mkurc-ant wants to merge 2 commits intogatecat:masterfrom
Open
[WIP] Group LRAM timings by cell configuration#29mkurc-ant wants to merge 2 commits intogatecat:masterfrom
mkurc-ant wants to merge 2 commits intogatecat:masterfrom
Conversation
gatecat
reviewed
Sep 13, 2022
timing/util/extract_cell_timings.py
Outdated
| # Leave only the relevant OUTREG setting | ||
| if rewritten[2] == "DOA" and "OUTREG_A" in cf["params"]: | ||
| cf["params"]["OUTREG"] = cf["params"]["OUTREG_A"] | ||
| del cf["params"]["OUTREG_A"] |
Owner
There was a problem hiding this comment.
this del of both params seems kind of suspicious to me
…ypes and configurations to JSON files Signed-off-by: Maciej Kurc <mkurc@antmicro.com>
Signed-off-by: Maciej Kurc <mkurc@antmicro.com>
82a80a3 to
b16d6d8
Compare
Owner
|
no worries if you've been busy but I'm wondering if the force-push fixed things at all? |
Contributor
Author
|
Hi, I'll do the rebase once I carve some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LRAMclock-to-q timings seem pretty high (~10ns) as the datasheet says that the worst case fmax is around 130MHz.To investigate this I isolated
LRAMfuzzing to a separate fuzzer, added randomizing output register enabling and added grouping of fuzzed timings by cell types and their configurations.This is a work in progress, currently I get the following results for the grouping:
For some combinations there are two timing sets while there should be only one.