Fix arithmetic warnings #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
approved these changes
Aug 3, 2025
Contributor
|
Thanks! Do you need a release with these change? |
Contributor
|
Feel free to ignore the windows ci failure, it is unrelated to the PR and will be fixed in a different PR. |
Contributor
Author
|
That would be helpful. Thank you. |
Contributor
Author
|
I can't seem to find the merge button. Would you be able to merge it? |
Contributor
Done! It is a bit late now in Europe, I will do a release tomorrow. If I forget, ping me, thanks! |
Contributor
Done: https://github.com/ami-iit/serial_cpp/releases/tag/v1.3.4 . |
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an arithmetic warning between double and enum. Deprecated in C++ 20 and this will fail in C++ 26