5879: Return CloseableIterator from QueryWebSocketClient #6447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob9786
changed the title
Rob9786
added
the
needs-reviewer
patchwork01
requested changes
Jan 28, 2026
| if (!hasNext()) { | ||
| throw new NoSuchElementException(); | ||
| } | ||
| return getRowList().remove(0); |
Collaborator
There was a problem hiding this comment.
This will be very inefficient with the ArrayList created in handleResults, as it copies all the data in handleResults, and it will need to move all the elements of the array along one place. I don't think we can merge this as is.
We can add a field for the current index in the list, call get instead of remove here, and stop copying the list in handleResults?
| if (timeoutMilliseconds >= 0) { | ||
| return future.get(timeoutMilliseconds, TimeUnit.MILLISECONDS); | ||
| } else { | ||
| return future.get(); |
Collaborator
There was a problem hiding this comment.
I think we should probably avoid calling the get methods every time we call the hasNext/next methods. We can hold the list in a field and check whether that's set before we fall back to the future.
patchwork01
removed
the
needs-reviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Issue
Feature". Note that before an issue is finished, you can still make a pull request by raising a separate issue
for your progress.
Tests
Documentation
separate issue for that below.