6443 - Updateding dockerfile to install updates #6456
+20
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-cache-in-state-store-committer-dockerfile
…urity-updates-and-clear-apt-cache-in-state-store-committer-dockerfile
Member
Author
|
I found the following also need updating. |
…urity-updates-and-clear-apt-cache-in-state-store-committer-dockerfile
…urity-updates-and-clear-apt-cache-in-state-store-committer-dockerfile
…-cache-in-state-store-committer-dockerfile
…-cache-in-state-store-committer-dockerfile
…-cache-in-state-store-committer-dockerfile
patchwork01
reviewed
Jan 28, 2026
| RUN yum install -y libzstd shadow-utils.x86_64 | ||
| RUN yum -y update-minimal --security --sec-severity=Critical,Important && \ | ||
| yum install -y libzstd shadow-utils.x86_64 && \ | ||
| yum clean all && rm -rf /var/cache/yum |
Collaborator
There was a problem hiding this comment.
Did you test this manually? We haven't used this Dockerfile in quite a while, does it build?
|
|
||
| # Install Amazon Corretto JDK | ||
| RUN apt-get update && apt-get install -y \ | ||
| RUN apt-get update && apt-get upgrade -y && apt-get install -y --no-install-recommends \ |
Collaborator
There was a problem hiding this comment.
Why the --no-install-recommends? I'm not sure what the impact will be, can you see what's different in the output?
Collaborator
There was a problem hiding this comment.
This doesn't match the other ECS Dockerfiles. Please can we keep the commands identical between all of them?
That includes:
java/compaction/compaction-job-execution/docker/Dockerfilejava/ingest/ingest-runner/docker/Dockerfilejava/bulk-export/bulk-export-task-execution/docker/Dockerfilejava/system-test/system-test-data-generation/docker/Dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Issue
Feature". Note that before an issue is finished, you can still make a pull request by raising a separate issue
for your progress.
Tests
Documentation
separate issue for that below.