Issue 6438 - Method to manage memory use in StateStoreProvider #6466

patchwork01 · 2026-01-22T16:03:54Z

Make sure you have checked all steps below.

Issue

My PR fully resolves the following issues. I've referenced an issue in the PR title, for example "Issue 1234 - My
Feature". Note that before an issue is finished, you can still make a pull request by raising a separate issue
for your progress.
- Resolves Improve & test management of heap space in state store committer #6438

Tests

My PR adds the following tests based on our test strategy OR does not need testing for this extremely good reason:
- Updated StateStoreProviderTest

Documentation

In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
separate issue for that below.
If I have added new Java code, I have added Javadoc that explains it following our conventions and style.
If I have added or removed any dependencies from the project, I have updated the NOTICES file.

…Provider

rtjd6554 · 2026-01-26T14:04:21Z

java/core/src/main/java/sleeper/core/properties/instance/TableStateProperty.java

+                    "be used in cases where the state store cache is the main use of memory, currently only in a " +
+                    "state store committer on the EC2 platform. This affects how many state stores can be cached in " +
+                    "memory.")
+            .defaultValue("1")


Is 1% an realistic value here for default?
(Know it was previously this, just checking logic is sound given we are making changes in this area)

We could remove the percentage property. When I was building this feature out I started off by evicting state stores to keep a certain percentage of the heap available. However, I switched to a fixed limit as I was testing and found that everything continued to work with <1% and it felt awkward setting the property to smaller percentages.

java/core/src/main/java/sleeper/core/statestore/StateStoreProvider.java

ctas582 · 2026-01-26T14:31:51Z

...e-committer/src/main/java/sleeper/statestore/committer/MultiThreadedStateStoreCommitter.java


                // Try to make sure there is going to be enough heap space available to process these commits
-                ensureEnoughHeapSpaceAvailable(messagesByTableId.keySet());
+                while (!stateStoreProvider.ensureEnoughHeapSpaceAvailable(messagesByTableId.keySet())) {


Getting java.lang.NullPointerException: Cannot invoke "sleeper.core.statestore.StateStoreProvider.ensureEnoughHeapSpaceAvailable(java.util.Collection)" because "this.stateStoreProvider" is null. It becomes not null when we receive our first message from the SQS queue, but if no messages are immediately available then this error is thrown. Add stateStoreProvider != null to while or wrap with an if?

I've reproduced that in MultiThreadedStateStoreCommitterLocalStackIT and fixed it, thanks.

ctas582 · 2026-01-26T14:37:56Z

java/core/src/main/java/sleeper/core/properties/instance/TableStateProperty.java

+                    "be used in cases where the state store cache is the main use of memory, currently only in a " +
+                    "state store committer on the EC2 platform. This affects how many state stores can be cached in " +
+                    "memory.")
+            .defaultValue("1")


We could remove the percentage property. When I was building this feature out I started off by evicting state stores to keep a certain percentage of the heap available. However, I switched to a fixed limit as I was testing and found that everything continued to work with <1% and it felt awkward setting the property to smaller percentages.

...e-committer/src/main/java/sleeper/statestore/committer/MultiThreadedStateStoreCommitter.java

ctas582 · 2026-01-28T15:47:15Z

...e-committer/src/main/java/sleeper/statestore/committer/MultiThreadedStateStoreCommitter.java

                        LoggedDuration.withShortOutput(startedAt, Instant.now()),
                        LoggedDuration.withShortOutput(lastReceivedCommitsAt, Instant.now()));

+                lastReceivedCommitsAt = Instant.now();


This is incorrectly getting set when no commits have been taken off the queue.

Sorry about that, I've reverted this change.

ctas582 · 2026-01-28T16:28:50Z

java/core/src/main/java/sleeper/core/util/JvmMemoryUse.java

+    }
+
+    @Override
+    public final String toString() {


As you've mentioned in the docs for this class, the field names are a bit complicated to understand. This implementation of toString results in logs that look like this:

[main] core.statestore.StateStoreProvider DEBUG - Keeping 100 MB free. Found memory use: JvmMemoryUse{totalMemory='80 MB', freeMemory='46 MB', maxMemory='6 GB'}

This makes it look like there isn't enough memory available, but there is. Should the loggers reference .availableMemory() instead of relying on .toString() to make the log output clearer? or should availableMemory be included in the toString() output?

I've adjusted the toString method and added unit tests for it.

…ommitter-heap-space

patchwork01 added 17 commits January 22, 2026 14:34

6438 Introduce JvmMemoryUse in StateStoreProviderTest

2c22423

6438 Rename heap space sizing properties

e55afe7

6438 Set up test

4c06e04

6438 Add FixedStateStoreProvider.singleTable

9645582

6438 Stop calling StateStoreProvider constructor from FixedStateStore…

bbd3761

…Provider

6438 Free up heap space

5c6c969

6438 Remove least recently used state store

21c5aad

6438 Handle required tables

ac2dc78

6438 Test target memory to keep free

afaa4be

6438 Test no size limit

05a8e4b

6438 Return whether freeing space was successful

3f2648b

6438 Trigger GC

ca2abf9

6438 Suppress SpotBugs for GC

1e5fbab

6438 Fail if min heap space is too high

c99a4b1

6438 Format memory sizes

326bca8

6438 Use StateStoreProvider method in MultiThreadedStateStoreCommitter

41cb6cc

6438 Resolve SpotBugs failure

1cddd3e

patchwork01 marked this pull request as ready for review January 23, 2026 15:42

patchwork01 added the needs-reviewer Pull requests that need a reviewer to be assigned label Jan 23, 2026

patchwork01 added 2 commits January 26, 2026 09:04

6438 Remove extra dependency

9087027

Merge branch 'develop' into 6438-state-store-committer-heap-space

4d68d2d

rtjd6554 reviewed Jan 26, 2026

View reviewed changes

java/core/src/main/java/sleeper/core/statestore/StateStoreProvider.java Outdated Show resolved Hide resolved

ctas582 suggested changes Jan 26, 2026

View reviewed changes

patchwork01 removed the needs-reviewer Pull requests that need a reviewer to be assigned label Jan 27, 2026

patchwork01 self-assigned this Jan 27, 2026

patchwork01 added 4 commits January 27, 2026 10:05

6438 Remove memory percentage property

4c04c94

6438 Reproduce and fix failure when committer receives no messages

b392e1a

6438 Tidy test setup

79d10cc

6438 Remove unused dependency

398e2ac

6438 Class Javadoc for QueueMessageCount

04f094e

patchwork01 removed their assignment Jan 27, 2026

patchwork01 added the needs-reviewer Pull requests that need a reviewer to be assigned label Jan 27, 2026

6438 Ensure heap space is available even when no messages are received

dccee14

patchwork01 commented Jan 27, 2026

View reviewed changes

...e-committer/src/main/java/sleeper/statestore/committer/MultiThreadedStateStoreCommitter.java Show resolved Hide resolved

patchwork01 self-assigned this Jan 28, 2026

patchwork01 removed the needs-reviewer Pull requests that need a reviewer to be assigned label Jan 28, 2026

6438 Configure minimum heap space in MultiThreadedStateStoreCommitter

0716428

patchwork01 assigned rtjd6554 and unassigned patchwork01 Jan 28, 2026

patchwork01 added the needs-reviewer Pull requests that need a reviewer to be assigned label Jan 28, 2026

ctas582 reviewed Jan 28, 2026

View reviewed changes

rtjd6554 assigned patchwork01 and unassigned rtjd6554 Jan 29, 2026

rtjd6554 approved these changes Jan 29, 2026

View reviewed changes

patchwork01 added 2 commits January 29, 2026 13:05

Merge remote-tracking branch 'origin/develop' into 6438-state-store-c…

06b0f0b

…ommitter-heap-space

6438 Revert checking whether messages were received in committer

21ae073

ctas582 approved these changes Jan 29, 2026

View reviewed changes

6438 Adjust JvmMemoryUse.toString

17747ba

patchwork01 removed their assignment Jan 29, 2026

patchwork01 removed the needs-reviewer Pull requests that need a reviewer to be assigned label Jan 29, 2026

patchwork01 self-assigned this Jan 29, 2026

patchwork01 merged commit a029831 into develop Jan 29, 2026
9 checks passed

patchwork01 deleted the 6438-state-store-committer-heap-space branch January 29, 2026 13:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 6438 - Method to manage memory use in StateStoreProvider #6466

Issue 6438 - Method to manage memory use in StateStoreProvider #6466

Uh oh!

patchwork01 commented Jan 22, 2026

Uh oh!

rtjd6554 Jan 26, 2026 •

edited

Loading

Uh oh!

ctas582 Jan 26, 2026

Uh oh!

patchwork01 Jan 27, 2026

Uh oh!

Uh oh!

ctas582 Jan 26, 2026

Uh oh!

patchwork01 Jan 27, 2026

Uh oh!

ctas582 Jan 26, 2026

Uh oh!

Uh oh!

ctas582 Jan 28, 2026

Uh oh!

patchwork01 Jan 29, 2026

Uh oh!

ctas582 Jan 28, 2026

Uh oh!

patchwork01 Jan 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Issue 6438 - Method to manage memory use in StateStoreProvider #6466

Issue 6438 - Method to manage memory use in StateStoreProvider #6466

Uh oh!

Conversation

patchwork01 commented Jan 22, 2026

Issue

Tests

Documentation

Uh oh!

rtjd6554 Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rtjd6554 Jan 26, 2026 •

edited

Loading