build tests by B-Rosenbaum · Pull Request #21 · gemtechd/build-tests

B-Rosenbaum · 2024-07-23T08:28:50Z

No description provided.

gemtechd

See the comments and work further on the task

gemtechd · 2024-07-23T09:23:49Z

modules/ecs6-class/line.js

+            throw new Error("n is not valid!")
+        }
+        if ((!(point1 instanceof Point)) || (!(point2 instanceof Point))) {
+            throw new Error("the object not instance of 'Point'!")


which point is not correct?

gemtechd · 2024-07-23T09:24:26Z

modules/ecs6-class/point.js

-    constructor({x=0, y=0}={}) {
+    constructor({ x = 0, y = 0 } = {}) {
+        if(typeof(x)!=="number" || typeof(y)!=="number" ){
+            throw new Error('argument is not a number!')


which parameter is not correct

gemtechd · 2024-07-23T09:25:53Z

modules/geometry-calculation.js


 const calculateDistance = (point1, point2) => {
+    if(point1===undefined || point2===undefined   ){
+        throw new Error('the function must get an arguments!')


which argument is missing?

gemtechd · 2024-07-23T09:27:40Z

modules/geometry-calculation.js

+    }
+    if((!(line1 instanceof Line))||(!(line2 instanceof Line))){
+        throw new Error("the arguments is not instance of 'Line'!")
+    }


which argument?

don't throw an error: You can calculate it

gemtechd · 2024-07-23T09:32:05Z

modules/geometry-calculation.js

+    if((!(line1 instanceof Line))||(!(line2 instanceof Line))){
+        throw new Error("the arguments is not instance of 'Line'!")
+    }
    if (line1.slope === line2.slope) {


what happens if the slope is still undefined or the n is still undefined?

don't throw an error: You can calculate it

gemtechd · 2024-07-23T09:36:41Z

test/modules/ecs6-class/line.test.js

+describe('RETURN_THE_POINT_ON_X_ASIS', () => {
+    it('should return the slope', () => {
+        line.getPointOnXAsis()
+        expect(line.getPointByY(2)).toEqual({ x: 1, y: 2 })


you are checking the getPointOnXAsis
your expect a result from a different function - getPointbyY
and the description is about something totally different...

gemtechd · 2024-07-23T09:37:58Z

test/modules/ecs6-class/line.test.js

+describe('RETURN_THE_POINT_ON_Y_ASIS', () => {
+    it('', () => {
+        line.getPointOnYAsis()
+        expect(line.getPointByX(2)).toEqual({ x: 2, y: 3 })


where is the description of the test?

test/modules/ecs6-class/line.test.js

test/modules/ecs6-class/point.test.js

gemtechd · 2024-07-23T09:39:48Z

test/modules/geometry-calculation.test.js

Missing test descriptions
Where are the mocks?

I'm waiting to see the mocks

gemtechd

See the comments
Build mocks in the tests

gemtechd · 2024-07-28T00:15:14Z

test/modules/ecs6-class/line.test.js

@@ -6,16 +6,32 @@ let line = new Line({ point1, point2 })
 let line1 = new Line({ point1, point2 })
 const myline = new Line({})


don't declare all parameters before the tests
do it inside each test apart

gemtechd · 2024-07-28T00:19:01Z

test/modules/ecs6-class/point.test.js

-describe('MOVE_VERTICAL', () => {
+describe('POINT_CONSTRUCTOR', () => {
+    it('should check the point object', () => {
+        expect(mypoint.x).toBe(0)


declare the parameters inside each test

gemtechd · 2024-07-28T00:20:11Z

test/modules/geometry-calculation.test.js

+let line4 = new Line({ point5, point6, slope: 1, n: 0 })
+let line5 = new Line({ point5, point4, slope: 1, n: 3 })
+let line6 = new Line({ point5, point4, slope: 1, n: 3 })



don't declare parameters in the head of the module, each test gets its own object to test on it

gemtechd · 2024-07-28T00:21:36Z

test/modules/geometry-calculation.test.js

+let line6 = new Line({ point5, point4, slope: 1, n: 3 })

 describe('CALCULATE_DISTANCE', () => {
    it('return the sqrt for distance to point1 with point2', () => {


the description should be: should return the distance between two points. No need to explain the calculation

gemtechd · 2024-07-28T00:22:27Z

test/modules/geometry-calculation.test.js

-    it('', () => {
-        expect(calculateJunctionPoint(line1,line1)).toBe(true)
+    it('should return true if the slope and the n equal in line1 and line2', () => {
+        expect(calculateJunctionPoint(line1, line1)).toBe(true)


should return true when both lines are the same

gemtechd · 2024-07-28T00:23:02Z

test/modules/geometry-calculation.test.js

-        expect(calculateJunctionPoint(line1,line2)).toBe(false)
+
+    it('should return false if the slope equal and the n not in line1 and line2', () => {
+        expect(calculateJunctionPoint(line1, line2)).toBe(false)


should return false if both lines are parallel

gemtechd · 2024-07-28T00:24:00Z

test/modules/geometry-calculation.test.js

I'm waiting to see the mocks

gemtechd · 2024-07-28T00:25:32Z

modules/geometry-calculation.js

+    }
+    if((!(line1 instanceof Line))||(!(line2 instanceof Line))){
+        throw new Error("the arguments is not instance of 'Line'!")
+    }


don't throw an error: You can calculate it

gemtechd · 2024-07-28T00:25:39Z

modules/geometry-calculation.js

+    if((!(line1 instanceof Line))||(!(line2 instanceof Line))){
+        throw new Error("the arguments is not instance of 'Line'!")
+    }
    if (line1.slope === line2.slope) {


don't throw an error: You can calculate it

B-Rosenbaum · 2024-07-28T12:12:36Z

if the function need to get arguments and she didn't get i need to throw error, no? ‫בתאריך יום א׳, 28 ביולי 2024 ב-3:26 מאת ‪gemtechd‬‏ <‪ ***@***.***‬‏>:‬

…

***@***.**** commented on this pull request. See the comments Build mocks in the tests ------------------------------ In test/modules/ecs6-class/line.test.js <#21 (comment)>: > @@ -6,16 +6,32 @@ let line = new Line({ point1, point2 }) let line1 = new Line({ point1, point2 }) const myline = new Line({}) don't declare all parameters before the tests do it inside each test apart ------------------------------ In test/modules/ecs6-class/point.test.js <#21 (comment)>: > @@ -1,8 +1,32 @@ const Point = require('../../../modules/ecs6-class/point') let mypoint = new Point() -describe('MOVE_VERTICAL', () => { +describe('POINT_CONSTRUCTOR', () => { + it('should check the point object', () => { + expect(mypoint.x).toBe(0) declare the parameters inside each test ------------------------------ In test/modules/geometry-calculation.test.js <#21 (comment)>: > - -let line1 = new Line({point1, point2,slope:2,n:3}) -let line2 = new Line({point3, point4,slope:2,n:5}) -let line3 = new Line({point3, point4,slope:4,n:3}) -let line4 = new Line({point5, point6,slope:1,n:0}) -let line5 = new Line({point5, point4,slope:1,n:3}) -let line6 = new Line({point5, point4,slope:1,n:3}) - - - +let line1 = new Line({ point1, point2, slope: 2, n: 3 }) +let line2 = new Line({ point3, point4, slope: 2, n: 5 }) +let line3 = new Line({ point3, point4, slope: 4, n: 3 }) +let line4 = new Line({ point5, point6, slope: 1, n: 0 }) +let line5 = new Line({ point5, point4, slope: 1, n: 3 }) +let line6 = new Line({ point5, point4, slope: 1, n: 3 }) don't declare parameters in the head of the module, each test gets its own object to test on it ------------------------------ In test/modules/geometry-calculation.test.js <#21 (comment)>: > - -let line1 = new Line({point1, point2,slope:2,n:3}) -let line2 = new Line({point3, point4,slope:2,n:5}) -let line3 = new Line({point3, point4,slope:4,n:3}) -let line4 = new Line({point5, point6,slope:1,n:0}) -let line5 = new Line({point5, point4,slope:1,n:3}) -let line6 = new Line({point5, point4,slope:1,n:3}) - - - +let line1 = new Line({ point1, point2, slope: 2, n: 3 }) +let line2 = new Line({ point3, point4, slope: 2, n: 5 }) +let line3 = new Line({ point3, point4, slope: 4, n: 3 }) +let line4 = new Line({ point5, point6, slope: 1, n: 0 }) +let line5 = new Line({ point5, point4, slope: 1, n: 3 }) +let line6 = new Line({ point5, point4, slope: 1, n: 3 }) describe('CALCULATE_DISTANCE', () => { it('return the sqrt for distance to point1 with point2', () => { the description should be: should return the distance between two points. No need to explain the calculation ------------------------------ In test/modules/geometry-calculation.test.js <#21 (comment)>: > }) }) }) describe('CALCULATE_JUNCTION_POINT', () => { - it('', () => { - expect(calculateJunctionPoint(line1,line1)).toBe(true) + it('should return true if the slope and the n equal in line1 and line2', () => { + expect(calculateJunctionPoint(line1, line1)).toBe(true) should return true when both lines are the same ------------------------------ In test/modules/geometry-calculation.test.js <#21 (comment)>: > }) - - it('', () => { - expect(calculateJunctionPoint(line1,line2)).toBe(false) + + it('should return false if the slope equal and the n not in line1 and line2', () => { + expect(calculateJunctionPoint(line1, line2)).toBe(false) should return false if both lines are parallel ------------------------------ In modules/geometry-calculation.js <#21 (comment)>: > const distance = Math.sqrt(distanceX + distanceY); return distance; } const calculateJunctionPoint = (line1, line2) => { + if(line1===undefined || line2===undefined ){ + throw new Error('the function must get an arguments!') + } + if((!(line1 instanceof Line))||(!(line2 instanceof Line))){ + throw new Error("the arguments is not instance of 'Line'!") + } don't throw an error: You can calculate it ------------------------------ In modules/geometry-calculation.js <#21 (comment)>: > const distance = Math.sqrt(distanceX + distanceY); return distance; } const calculateJunctionPoint = (line1, line2) => { + if(line1===undefined || line2===undefined ){ + throw new Error('the function must get an arguments!') + } + if((!(line1 instanceof Line))||(!(line2 instanceof Line))){ + throw new Error("the arguments is not instance of 'Line'!") + } if (line1.slope === line2.slope) { don't throw an error: You can calculate it ------------------------------ On test/modules/geometry-calculation.test.js <#21 (comment)>: I'm waiting to see the mocks — Reply to this email directly, view it on GitHub <#21 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BJ6LP7DLM2IN7FDFKBC467TZOQ3D7AVCNFSM6AAAAABLJ5G7YCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMBTGI2DONBSGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

build tests

df095f0

gemtechd reviewed Jul 23, 2024

View reviewed changes

C-Grin added 3 commits July 24, 2024 20:37

fix the tests

2120381

fix tests

5e5922e

fixxxxx

d828d0b

gemtechd reviewed Jul 28, 2024

View reviewed changes

gemtechd added the ashdod label Jul 28, 2024

add changes

4594b47

		@@ -6,16 +6,32 @@ let line = new Line({ point1, point2 })
		let line1 = new Line({ point1, point2 })
		const myline = new Line({})

Conversation

B-Rosenbaum commented Jul 23, 2024

Uh oh!

gemtechd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemtechd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

B-Rosenbaum commented Jul 28, 2024 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants