my tests by M-Kroizer · Pull Request #35 · gemtechd/build-tests

M-Kroizer · 2024-07-28T14:59:10Z

No description provided.

M-Kroizer · 2024-07-28T15:00:32Z

I have tried a lot of ways to mock the class line while having the option to change the values of n and slope in the ctor.
i tried to make the mock class mockline at mock folder and to put there also furthermockline class but it didn't work well.
i have tried also to mock dynamically the line (deleting the mockline class from mock)
but now the mock doesn't work!!
I'm pushing now my not completed work
I would be happy to get some guidance on how to get on.

gemtechd

Update your code
the tests weren't reviewed now

gemtechd · 2024-08-01T05:23:11Z

modules/ecs6-class/__mocks__/line.js

+//     })
+//   };
+// });
+


Why do you push remarks?

gemtechd · 2024-08-01T05:23:59Z

modules/ecs6-class/line.js

-    constructor({ point1 = new Point(), point2 = new Point(), n = undefined, slope = undefined }) {
+    constructor({ point1 = new Point(), point2 = new Point(), n = undefined, slope = undefined }={}) {
+        if(!(point1 instanceof Point) || !(point2 instanceof Point)){
+            throw new Error('points must be instances of point')


Which point throws the error?

gemtechd · 2024-08-01T05:25:05Z

modules/ecs6-class/line.js


-    calculateSlope = () => {
+    calculateSlope () {
        this.slope = (this.point1.y - this.point2.y) / (this.point1.x - this.point2.x)


did you check that the x for both points are not identical? =>should divide by zero

gemtechd · 2024-08-01T05:25:18Z

modules/ecs6-class/line.js


-    calculateNOfLineFunction = () => {
+    calculateNOfLineFunction(){
        this.n = this.point1.y - this.slope * this.point1.x


is the slope calculated??

gemtechd · 2024-08-01T05:25:36Z

modules/ecs6-class/line.js

-    getPointByX(x) {
+    getPointByX(x=0) {
+        if(typeof(x)!='number'){
+            throw new Error('value must be a number')


use always !== or ===

gemtechd · 2024-08-01T05:26:53Z

modules/ecs6-class/line.js

+        if(typeof(x)!='number'){
+            throw new Error('value must be a number')
+        }
        let y = this.slope * x + this.n


are the n and slope calculated?

gemtechd · 2024-08-01T05:27:15Z

modules/ecs6-class/line.js

+        if(typeof(y)!='number'){
+            throw new Error('value must be a number')
+        }
        let x = (y - this.n) / this.slope;


are the n and the slope calculated?

gemtechd · 2024-08-01T05:27:59Z

modules/geometry-calculation.js

+        throw new Error('must enter 2 lines')
+    if(!(line2 instanceof Line)||!(line1 instanceof Line))
+        throw new Error('lines must be instances of Line')
    if (line1.slope === line2.slope) {


Are the slopes calculated?

gemtechd · 2024-08-01T05:28:18Z

modules/geometry-calculation.js

+    if(! (line instanceof Line))
+        throw new Error('line must be instance of Line')
    const proxyLine = new Line({ point1: line.point1, point2: point })
    proxyLine.calculateSlope()


Is the slope calculated?

gemtechd · 2024-08-01T05:28:44Z

package.json

+    "coverage":"npm test -- --coverage"
  },
  "dependencies": {
    "jest": "^29.7.0"


this is really not the good place

M-Kroizer added 2 commits July 21, 2024 13:03

add tests for all pages still without mocks

bd52414

add __mocks__ folder but not everything works well

a710313

gemtechd reviewed Aug 1, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

my tests#35

my tests#35
M-Kroizer wants to merge 2 commits intogemtechd:mainfrom
M-Kroizer:tests

M-Kroizer commented Jul 28, 2024

Uh oh!

M-Kroizer commented Jul 28, 2024

Uh oh!

gemtechd left a comment

Uh oh!

gemtechd Aug 1, 2024

Uh oh!

gemtechd Aug 1, 2024

Uh oh!

gemtechd Aug 1, 2024

Uh oh!

gemtechd Aug 1, 2024

Uh oh!

gemtechd Aug 1, 2024

Uh oh!

gemtechd Aug 1, 2024

Uh oh!

gemtechd Aug 1, 2024

Uh oh!

gemtechd Aug 1, 2024

Uh oh!

gemtechd Aug 1, 2024

Uh oh!

gemtechd Aug 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

M-Kroizer commented Jul 28, 2024

Uh oh!

M-Kroizer commented Jul 28, 2024

Uh oh!

gemtechd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants