Open
Conversation
Author
|
merge main with tests in the first time |
gemtechd
reviewed
Aug 6, 2024
Owner
gemtechd
left a comment
There was a problem hiding this comment.
You need to update the code also
because the code misses some checks before the tests
Author
|
I know that, I wrote that by myself, yesterday I asked you to give me the
next task, although I have not finished yet.
בתאריך יום ג׳, 6 באוג׳ 2024 ב-19:39 מאת gemtechd <
***@***.***>:
… ***@***.**** commented on this pull request.
You need to update the code also
because the code misses some checks before the tests
—
Reply to this email directly, view it on GitHub
<#40 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKE5TX7JSNIICS3QF7QIYJTZQD35TAVCNFSM6AAAAABMCGBWKOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMRRG44TCMJTHA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Owner
|
Author
|
Ok, I'll check it out.
בתאריך יום ד׳, 7 באוג׳ 2024 ב-10:22 מאת gemtechd <
***@***.***>:
…
1. everyone wrote the task, and every girl got the review the same way
2. You need to make better the code, for example check the code that
the function got all parameters
3. You need to go through the first task with a little bit frustration
that the next task you'll be on the right path from the beginning,
4. btw you were invited a long time ago to the github - this things
are up to you
—
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKE5TXYVJX74QAXJ37HTM3DZQHDJ3AVCNFSM6AAAAABMCGBWKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZSG44TKMJQGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Author
|
I made a new commit , but I don't see that in the pull requests, only in mine. |
Owner
|
Send it to a PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.