Add PancakeSwap V3 deployment for ZkSync / Monad#994
Conversation
Add ZkSync chain to PancakeSwap router deployment with QuoterV2, Universal Router and Permit2 addresses.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request extends the PancakeSwap V3 deployment configurations to include the ZkSync chain. This integration enables the system to correctly identify and utilize the necessary smart contract addresses for PancakeSwap V3 operations on ZkSync, facilitating broader compatibility and functionality. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the PancakeSwap V3 deployment details for the ZkSync chain. However, the addresses provided for the Universal Router and Permit2 contracts are incorrect and swapped, leading to a complete denial of service for PancakeSwap V3 swaps on ZkSync. I've provided suggestions to correct the addresses and to include a comment with a source link for the new contract addresses to enhance code maintainability.
Add ZkSync and Momad to PancakeSwap router deployment with QuoterV2, Universal Router and Permit2 addresses.
ZkSync txs:
Monad txs: