Skip to content

Add relay and rename fetchPermit2#1773

Merged
gemcoder21 merged 2 commits intomainfrom
relay3
Mar 6, 2026
Merged

Add relay and rename fetchPermit2#1773
gemcoder21 merged 2 commits intomainfrom
relay3

Conversation

@0xh3rman
Copy link
Contributor

@0xh3rman 0xh3rman commented Mar 6, 2026

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the SwapService by standardizing method naming conventions, specifically renaming fetchPermit2ForQuote to getPermit2ForQuote for better clarity. Concurrently, it updates the core subproject to its latest version, ensuring the project benefits from the most recent developments and bug fixes in that dependency.

Highlights

  • Method Renaming: The fetchPermit2ForQuote method has been consistently renamed to getPermit2ForQuote across the SwapService and its mock implementation for improved clarity and adherence to Swift's API design guidelines.
  • Subproject Update: The core subproject has been updated to a newer commit hash, integrating the latest changes and improvements from that dependency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Packages/FeatureServices/SwapService/SwapService.swift
    • Renamed the fetchPermit2ForQuote method to getPermit2ForQuote within the getPermit2Approval function.
  • Packages/FeatureServices/SwapService/TestKit/GemSwapperMock.swift
    • Updated the mock implementation by renaming fetchPermit2ForQuote to getPermit2ForQuote.
  • core
    • The core subproject was updated to a new commit hash.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily involves renaming the method fetchPermit2ForQuote to getPermit2ForQuote for better semantic clarity and consistency. This change is correctly propagated through SwapService.swift and the test mock GemSwapperMock.swift. Additionally, the core submodule has been updated. The changes are straightforward and improve the codebase's maintainability.

@0xh3rman 0xh3rman changed the title Add relay and fetchPermit2 -> getPermit2 Add relay and rename fetchPermit2 Mar 6, 2026
@gemcoder21 gemcoder21 merged commit b491725 into main Mar 6, 2026
1 check passed
@gemcoder21 gemcoder21 deleted the relay3 branch March 6, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants