Fix ENS name resolution by passing authenticated API provider

[DRadmir]

NameService was using a default GemAPIService() without device authentication, causing "Missing header: x-device-id" errors after name resolution was moved to device-authenticated API endpoints.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the name resolution process where the NameService was failing to authenticate its API requests. The fix involves updating the service initialization to correctly provide an authenticated API provider, thereby resolving the "Missing header: x-device-id" errors and restoring proper functionality for ENS name resolution.

Highlights

• ENS Name Resolution Fix: Resolved an issue where ENS name resolution failed due to missing device authentication headers by ensuring the NameService is initialized with an authenticated API provider.
• Dependency Injection Update: Modified the ServicesFactory to explicitly pass an authenticated apiService instance to the NameService constructor, replacing the previous default unauthenticated instance.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• Gem/Services/ServicesFactory.swift
  • Updated the initialization of NameService to pass an authenticated apiService.
• Packages/ChainServices/NameService/NameService.swift
  • Refactored the initializer signature for NameService for conciseness.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an ENS name resolution issue by correctly injecting an authenticated API provider into the NameService. The change in ServicesFactory is correct. However, to prevent this issue from happening again in the future, I've suggested removing the default initializer for NameService to enforce explicit dependency injection. This will make the code more robust.

[gemini-code-assist]

To prevent this bug from recurring, it's better to remove the default parameter for the provider. This will enforce dependency injection at all call sites and ensure that a properly configured provider is always used, making the code safer and preventing accidental use of an unauthenticated service.

Suggested change

	public init(provider: any GemAPINameService = GemAPIService()) {
	public init(provider: any GemAPINameService) {