Skip to content

Don't close shared dbus connection#74

Merged
gen2brain merged 1 commit intogen2brain:masterfrom
andrewheberle:patch-1
Dec 11, 2025
Merged

Don't close shared dbus connection#74
gen2brain merged 1 commit intogen2brain:masterfrom
andrewheberle:patch-1

Conversation

@andrewheberle
Copy link
Contributor

This PR would close #73

@gen2brain
Copy link
Owner

@ossenthusiast Such a function would make no sense on other platforms, though. The question is: what exactly does the systray package do, and what would the correct behaviour be? Not closing should be done only if it uses some global connection that it can reuse, if that is an option at all. I do not have time to explore all this currently.

@andrewheberle
Copy link
Contributor Author

Based on the documentation of the dbus package used Close() should never be called on a shared *dbus.Conn:

https://pkg.go.dev/github.com/godbus/dbus#Conn.Close

@gen2brain gen2brain merged commit ab78edd into gen2brain:master Dec 11, 2025
3 checks passed
@gen2brain
Copy link
Owner

Yeah, that makes sense. Why else would it be named "shared", all clear now, I think I already read that once and I forgot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shared dbus connection should not be closed

2 participants