Conversation
- agent.py - action.py - computer.py
psarka
requested changes
Apr 4, 2025
Collaborator
|
Sweet, thank you! ❤️ I left some comments if you don't mind :) |
Contributor
Author
|
@psarka thanks for the feedback, got them resolved |
Collaborator
|
Awesome! Can you run |
Contributor
Author
|
you got it @psarka would be nice with some CI checks here at some point :) |
Collaborator
|
There is a CI check, but I need to approve for it to run. I think it's because it's your first contribution:
Anyways, everything is green now 🥳 |
psarka
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in
CONTRIBUTING.mdI've added some missing doc strings.Can't confirm they are 100% correct since I don't have an invite yet. ;)
Doc strings added to:
agent.pyaction.pycomputer.py