Skip to content

fix utils/generateTemplateString() in case of props is null or undefined #11791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
allyoucanmap merged 1 commit into from
Dec 10, 2025
Merged

fix utils/generateTemplateString() in case of props is null or undefined #11791

allyoucanmap merged 1 commit into from
Dec 10, 2025

Conversation

@stefanocudini
Copy link
Member

@stefanocudini stefanocudini commented Dec 10, 2025

  • fix generateTemplateString() in case of props is null or undefined
  • added a new test for this case

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
the bug show in case of search services use null or undefined sub props:
image

What is the new behavior?
strip all null o undefined subprop with empty char

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

@stefanocudini stefanocudini self-assigned this Dec 10, 2025
@stefanocudini stefanocudini linked an issue Dec 10, 2025 that may be closed by this pull request
Search plugin show null or undefined in displayName #11792
Open
1 task
@allyoucanmap allyoucanmap merged commit 0cc2564 into geosolutions-it:master Dec 10, 2025
11 checks passed
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Dec 12, 2025
@tdipisa tdipisa added this to the 2025.02.01 milestone Dec 12, 2025
@tdipisa
Copy link
Member

tdipisa commented Dec 12, 2025

@ElenaGallo please check this in dev and let us know for the backport

@tdipisa tdipisa added backport 2025.02.xx and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Dec 12, 2025
github-actions bot pushed a commit that referenced this pull request Dec 12, 2025
@stefanocudini @github-actions
Fix #11792 Search plugin show null or undefined in displayName (#11791)
cd87dfb 
(cherry picked from commit 0cc2564)
@github-actions github-actions bot mentioned this pull request Dec 12, 2025
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

Successfully created backport PR for 2025.02.xx:

mahesh-wor pushed a commit to mahesh-wor/MapStore2 that referenced this pull request Dec 17, 2025
@stefanocudini @mahesh-wor
Fix geosolutions-it#11792 Search plugin show null or undefined in dis…
2829034 
…playName (geosolutions-it#11791)
@ElenaGallo
Copy link
Contributor

ElenaGallo commented Dec 18, 2025 •
edited
Loading

Test passed on DEV, @allyoucanmap backport can be merged here: #11809

tdipisa pushed a commit that referenced this pull request Jan 5, 2026
@github-actions @stefanocudini
Fix #11792 Search plugin show null or undefined in displayName (#11791)…
7b0006e 
… (#11809)

(cherry picked from commit 0cc2564)

Co-authored-by: Stefano Cudini <stefano.cudini@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allyoucanmap allyoucanmap allyoucanmap approved these changes

Assignees

@stefanocudini stefanocudini

Labels

backport 2025.02.xx bug

Projects

None yet

Milestone

2025.02.01

Development

Successfully merging this pull request may close these issues.

Search plugin show null or undefined in displayName

4 participants

@stefanocudini @tdipisa @ElenaGallo @allyoucanmap