Skip to content

Conversation

@offtherailz
Copy link
Member

Description

Fix #11841 repair and improve axios issues.

In particular the issue was that the tests were not well written, and causing both random failure and false positives.

  • Most of them where performing real requests that where failing, and the exception was used to check data. This slows down the system, and may generate random failures. Repaired with mockAxios
  • Some tests where not testing the real functionality, always being succesful. This hidden the fact that the autoDetectCors: false was not supported, even if documented. I needed to repair axios functionality for autoDetectCors = false to make them effectively run.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
#11841

What is the new behavior?
Fix #11841 repair and improve axios issues

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Randomly Failing test on ajax lib

2 participants