final commit, had a stab on the unit testing, but

[isaklafleur]

Hi,

I spend approx 6 hours to get this working. To bet the logic in place took 2 hours. Rest was spent on styling, refactor and trying to figure out how to do the unit testing with the github api... :)

I have tried to refactored the code as much as possible. Two questions I would like to ask and maybe can be answered on an possible future interview.

1. What is best practice, to create the html-elements. In the html code or in the javascript code? I did both. Please see examples:

Here I create the html tags in the index.html and only updating the "innerHTML" of the tags in the javascript code.

      <div id="user-info">
        <div id="col-left">
          <img id="github-profile-image" alt="Profile Image">
        </div>
        <div id="col-right">
          @<i><span id="github-username"></span></i><br>
          <span id="github-fullname"></span><br>
          <span id="github-userbio"></span>
        </div>
      </div>

Here I create and append most of the html tags to this parent in the javascript code instead.
<div id="user-repos"></div>

2. I tried to figure out how to do Unit Testing on the Github API. I know how to do it when functions returns values, but my functions only writes to the index file and do not return anything. Or maybe I misunderstood it.

Looking forward to hear from you!

Isak