fix: prevent potential null access when retrieving source paths #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgilpin
reviewed
Mar 18, 2021
| classType.getPackageName().replace('.', '/'), | ||
| classType.getClassFile().getSourceFile() | ||
| }; | ||
| final List<String> parts = new ArrayList(Arrays.asList("src", "main", "java")); |
Contributor
There was a problem hiding this comment.
I thought we weren't doing this. In VSCode, if the project structure doesn't match this convention, it can actually break the "View source" link.
Collaborator
Author
There was a problem hiding this comment.
We don't have a better alternative right now. The source path we can grab from the jar is partial and may match many paths. We have another branch open to explore better solutions.
Collaborator
Author
There was a problem hiding this comment.
Just to be clear, this heuristic is more likely to resolve to a real file than otherwise until we have a better solution in place.
Contributor
There was a problem hiding this comment.
No, I think we should pull this out. It makes things worse in VSCode which is the #1 target environment.
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.