Skip to content

Conversation

@ahtrotta
Copy link
Contributor

@ahtrotta ahtrotta commented Mar 25, 2024

Fixes #1641

@ahtrotta ahtrotta self-assigned this Mar 25, 2024
@github-actions
Copy link

github-actions bot commented Mar 25, 2024

AppMap runtime code review

Summary Status
Failed tests ✅ All tests passed
API changes 0️⃣ No API changes
Security flaws ✅ None detected
Performance problems ✅ None detected
Code anti-patterns ✅ None detected
New AppMaps 0️⃣ No new AppMaps

@kgilpin
Copy link
Contributor

kgilpin commented Mar 26, 2024

@ahtrotta if we can hit a few of the most important cases in this PR, then we can always follow-on with other cases later. We don't have to get all of them right away.

@ahtrotta
Copy link
Contributor Author

@ahtrotta if we can hit a few of the most important cases in this PR, then we can always follow-on with other cases later. We don't have to get all of them right away.

I'm having a bit of troubling getting things to behave the way I want to.

@ahtrotta ahtrotta force-pushed the feat/show-loading-spinner branch from 727af3b to 0c1579c Compare March 26, 2024 19:49
@ahtrotta ahtrotta force-pushed the feat/show-loading-spinner branch 2 times, most recently from 8c230ee to 967585a Compare March 26, 2024 19:59
@ahtrotta ahtrotta force-pushed the feat/show-loading-spinner branch from 967585a to c6ee367 Compare March 26, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The UI has some indication that it's working when performing a long-running task

3 participants