Skip to content

fix: merge interface fields into derived types in SDL generation #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kleberbaum wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

fix: merge interface fields into derived types in SDL generation #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/pylon-dev/src/builder/schema/schema-parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,20 @@ export class SchemaParser {
if (!derivedSchemaType.implements.includes(interfaceName)) {
derivedSchemaType.implements.push(interfaceName)
}

// Ensure the derived type includes all interface fields.
// Without this, GraphQL schema validation fails:
// "Interface field IFoo.x expected but Bar does not provide it."
if (targetInterface) {
for (const ifaceField of targetInterface.fields) {
const alreadyHasField = derivedSchemaType.fields.some(
f => f.name === ifaceField.name
)
if (!alreadyHasField) {
derivedSchemaType.fields.push({...ifaceField})
}
}
}
}

// Check if this derived type is also a base type for other types
Expand Down