Perform background check after images are loaded#11
Open
michalbiarda wants to merge 1 commit intogetgrav:developfrom
Open
Perform background check after images are loaded#11michalbiarda wants to merge 1 commit intogetgrav:developfrom
michalbiarda wants to merge 1 commit intogetgrav:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys,
first of all thanks for an amazing template. I like it very much.
I started playing with it recently and noticed that background check feature sometimes doesn't work properly. I dug a little bit and it looks like the script is not taking into account when images are loaded. When JS script starts before images are loaded (for example when all assets are cached in a browser), background check is incorrect.
My fix forces the script to wait until all checked images are loaded. Please merge it if you want.
Best regards,
Michał Biarda