Skip to content

Fix installation error (MSVCP140.dll missing) by auto-installing VC++ runtime #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atavism wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix installation error (MSVCP140.dll missing) by auto-installing VC++ runtime #1369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions windows/packaging/exe/inno_setup.iss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,15 @@ Name: "{app}\{{APP_NAME}}\WebView2"; Permissions: everyone-modify

[Downloads]
Source: "https://go.microsoft.com/fwlink/p/?LinkId=2124703"; DestFile: "{tmp}\MicrosoftEdgeWebView2Setup.exe"; Flags: external
; Visual C++ 2015–2022 Redistributable (x64)
Source: "https://aka.ms/vs/17/release/vc_redist.x64.exe"; DestFile: "{tmp}\vc_redist.x64.exe"; Flags: external

[Run]
; Install VC++ runtime if needed (fixes MSVCP140/VCRUNTIME errors)
Filename: "{tmp}\vc_redist.x64.exe"; Parameters: "/install /quiet /norestart"; \
StatusMsg: "Installing Microsoft Visual C++ 2015–2022 Runtime (x64)…"; \
Check: NeedsVCRedist and FileExists(ExpandConstant('{tmp}\vc_redist.x64.exe')); \
Flags: runhidden
Filename: "{tmp}\MicrosoftEdgeWebView2Setup.exe"; Parameters: "/silent /install"; StatusMsg: "Installing WebView2 Runtime..."; Check: NeedsWebView2Runtime and FileExists(ExpandConstant('{tmp}\MicrosoftEdgeWebView2Setup.exe'))
; Launch the app after WebView2 has been installed
Filename: "{app}\\{{EXECUTABLE_NAME}}"; Description: "{cm:LaunchProgram,{{DISPLAY_NAME}}}"; Flags: {% if PRIVILEGES_REQUIRED == 'admin' %}runascurrentuser{% endif %} nowait postinstall skipifsilent
Expand All @@ -63,3 +70,19 @@ begin
Result := True; // WebView2 is not installed
end;
end;


function NeedsVCRedist(): Boolean;
var
Installed: Cardinal;
begin
// HKLM\SOFTWARE\Microsoft\VisualStudio\14.0\VC\Runtimes\x64 Installed = 1
if RegQueryDWordValue(HKLM64, 'Software\Microsoft\VisualStudio\14.0\VC\Runtimes\x64', 'Installed', Installed) then
begin
Result := (Installed <> 1);
end
else
begin
Result := not FileExists(ExpandConstant('{sys}\MSVCP140.dll'));
end;
end;
Loading