feat(linters): migrate bash linters/formatters to use mise

.tool-versions

@@ -13,8 +13,6 @@ golang 1.23.4
 # The most common case is nodejs.
 ## <<Stencil::Block(toolver)>>
 # The below tools are used by all repositories when using devbase
-shellcheck 0.9.0
-shfmt 3.7.0
 goreleaser 1.20.0
 terraform 1.4.4
 ## <</Stencil::Block>>

shell/lib/mise.sh

@@ -252,6 +252,14 @@ mise_exec_tool_with_bin() {
   shift
   local binName="$1"
   shift
+
+  # asdf shims take precedence in the PATH,
+  # so remove it in CI before execution.
+  local asdfShim="${ASDF_DIR:-$HOME/.asdf}/shims/$binName"
+  if in_ci_environment && [[ -f $asdfShim ]]; then
+    rm "$asdfShim"
+  fi
+
   local version
   version="$(get_tool_version "$binName")"
   MISE_GITHUB_TOKEN=$(github_token) run_mise exec "$toolName@$version" -- "$binName" "$@"

shell/linters/bash.sh

@@ -16,15 +16,19 @@ find_shell_files() {
 }
 
 shellcheck_linter() {
-  find_shell_files | xargs -n40 "$SHELLCHECKPATH" -x -P SCRIPTDIR
+  # Wrapper script already sets external sources & script directory
+  # source path.
+  find_shell_files | xargs -n40 "$SHELLCHECKPATH"
 }
 
 shellfmt_linter() {
-  find_shell_files | xargs -n40 "$SHELLFMTPATH" -s -d
+  # Wrapper script already sets --simplify
+  find_shell_files | xargs -n40 "$SHELLFMTPATH" --diff
 }
 
 shellfmt_formatter() {
-  find_shell_files | xargs -n40 "$SHELLFMTPATH" -w -l
+  # Wrapper script already sets --simplify
+  find_shell_files | xargs -n40 "$SHELLFMTPATH" --write --list
 }
 
 linter() {

shell/shellcheck.sh

@@ -1,14 +1,15 @@
 #!/usr/bin/env bash
-# This is a wrapper around asdf to run shellcheck.
+# This is a wrapper around mise to run shellcheck.
 # Useful for using the correct version of shellcheck
 # with your editor.
 set -e
 
 DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)"
 
-# shellcheck source=./lib/asdf.sh
-source "$DIR/lib/asdf.sh"
+# shellcheck source=./lib/mise/stub.sh
+source "$DIR/lib/mise/stub.sh"
 
 # Always set the correct script directory.
-args=("-P" "SCRIPTDIR" "-x" "$@")
-asdf_devbase_exec shellcheck "${args[@]}"
+args=(--external-sources --source-path=SCRIPTDIR "$@")
+
+mise_exec_tool shellcheck "${args[@]}"

shell/shfmt.sh

@@ -1,15 +1,15 @@
 #!/usr/bin/env bash
-# This is a wrapper around asdf to run shfmt.
+# This is a wrapper around mise to run shfmt.
 # Useful for using the correct version of shfmt
 # with your editor.
 set -e
 
 DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)"
 
-# shellcheck source=./lib/asdf.sh
-source "$DIR/lib/asdf.sh"
+# shellcheck source=./lib/mise/stub.sh
+source "$DIR/lib/mise/stub.sh"
 
 # Always set simplify mode.
-args=("-s" "$@")
+args=("--simplify" "$@")
 
-asdf_devbase_exec shfmt "${args[@]}"
+mise_exec_tool shfmt "${args[@]}"

versions.yaml

@@ -13,6 +13,9 @@ mage: 1.14.0
 ## Sync with templates/scripts/devbase.sh.tpl
 gojq: v0.12.18
 
+shellcheck: 0.9.0
+shfmt: 3.7.0
+
 # protobuf formatters/plugins/tools/etc
 buf: 1.60.0
 protoc-gen-validate: 0.6.7