Xcodemake argument string replacement#178
Merged
cameroncooke merged 1 commit intomainfrom Jan 17, 2026
Merged
Conversation
The executeXcodemakeCommand function was using .replace() to remove project directory paths from arguments, which would corrupt any argument containing the project directory path as a substring (not just as a prefix). Changed to use .startsWith() and .substring() to only remove the project directory when it appears as a path prefix, matching the approach already used in doesMakeLogFileExist. Fixes XCODEBUILD-MCP-12S9
Contributor
Author
|
Cursor Agent can help with this pull request. Just |
commit: |
cameroncooke
approved these changes
Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
xcodemakecommand argument corruption during macOS builds.The global string replacement of the project directory in all arguments was causing Swift source file paths and other arguments to be malformed, leading to build failures. The fix ensures replacement only occurs when the project directory is a prefix of an argument.
Fixes XCODEBUILD-MCP-12S9
Note
Fixes xcodemake argument handling
executeXcodemakeCommand, replace global string replacement with prefix-only stripping ofprojectDir/to avoid corrupting non-path argumentsCHANGELOG.mdunder Fixed to note the xcodemake argument corruption fixWritten by Cursor Bugbot for commit 9afdfc7. This will update automatically on new commits. Configure here.