chore: add LANGUAGE ASM_MASM property to source files#145
Merged
JoshuaMoelans merged 2 commits intogetsentryfrom Jan 26, 2026
Merged
chore: add LANGUAGE ASM_MASM property to source files#145JoshuaMoelans merged 2 commits intogetsentryfrom
LANGUAGE ASM_MASM property to source files#145JoshuaMoelans merged 2 commits intogetsentryfrom
Conversation
jpnurmi
reviewed
Jan 26, 2026
Collaborator
jpnurmi
left a comment
jpnurmi
left a comment
There was a problem hiding this comment.
What about misc/capture_context_win_arm64.asm above?
Member
Author
|
@jpnurmi wasn't sure if that was necessary, but doesn't hurt to add; IIUC we need |
This was referenced Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user reported an issue where
nasm.exewas being used to pick up our.asmfiles, but since the files in question useMASMsyntax this led to an error.I suggested we could add the
LANGUAGEproperty to fix (which was confirmed by the user that this works).