Revert "feat: add Pi coding agent support"#26
Conversation
This reverts commit 170aac5.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR reverts PR #20, which had added Pi as a full agent definition with MCP config writing support. According to issue #25, this approach was incorrect because Pi's MCP support is extension-based and optional, unlike other agents (Claude, Cursor, Codex, etc.) that have well-known, fixed MCP config paths. Writing .pi/mcp.json during dotagents install would either create dead files for users without the MCP extension or conflict with existing user-managed configs. The correct approach for Pi is to use symlinks configured in agents.toml, which gives Pi access to dotagents-managed skills without managing MCP config.
Changes:
- Removed pi agent from the agent registry and imports
- Deleted the pi agent definition file
- Removed pi-specific path handling for MCP config
- Removed all pi-related tests
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/agents/registry.ts | Removed pi import and removed pi from ALL_AGENTS array (now 5 agents instead of 6) |
| src/agents/registry.test.ts | Updated test to expect 5 agents instead of 6, removed pi-specific test assertions, and deleted entire pi serializer test suite |
| src/agents/paths.ts | Removed pi case from getUserMcpTarget switch statement |
| src/agents/paths.test.ts | Removed test for pi's user MCP target path and skill discovery paths |
| src/agents/definitions/pi.ts | Completely deleted the pi agent definition file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Reverts #20
See: