Merged
Conversation
When GIT_TAG uses a variable like ${FOO_REF}, resolve it to the
corresponding set() definition and update that line instead of the
FetchContent_Declare block.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vaind
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update-CMakeFileto handleGIT_TAG ${VAR}references where the actual value is defined in aset()callParse-CMakeFetchContentnow resolves CMake variable references to their actual valuesset()line is modified instead of theGIT_TAGline, preserving the variable indirection# versioncommentsSee also
Test plan
Invoke-Pester updater/tests/update-dependency-cmake.Tests.ps1)