fix: Add packages: write permission to publish workflow#7207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages: writeto the workflow-levelpermissionsblock inpublish.ymlProblem
Commit
0269363added explicit least-privilegepermissionsblocks to all workflow files (fixing CodeQL alerts). Thepublish.ymlblock was set tocontents: read+issues: write, butpackages: writewas omitted.When an explicit
permissionsblock is declared, GitHub treats it as a strict allowlist —secrets.GITHUB_TOKENloses any permissions not listed. This caused Docker pushes to ghcr.io to fail:The
secrets.GITHUB_TOKEN(passed asDOCKER_GHCR_IO_PASSWORD) is the only token that can authenticate to ghcr.io, so it must carrypackages: write.Fix
Add
packages: writeto the permissions block. No changes to Craft or any other files needed.Fixes https://github.com/getsentry/publish/actions/runs/22119619739 and https://github.com/getsentry/publish/actions/runs/22119618913